circagraph
Sign inSign up

openchronology/timeline-app on GitHub

The OpenChronology repository on GitHub, mirrored by och-import-github: issues and pull requests as durations (ongoing while open), what happened to them as moments, plus releases, milestones, commits and branches. The Branches view shows the most recently active branches each in a track of its own.

Source: https://github.com/openchronology/timeline-app

3,131 moments · 2026-10-05 CE 20:21:49 UTC – 2026-11-16 CE 12:10:45 UTC · by @athan · @athan

#562 Make a comma inside a tag a semicolon, so separations select every tag

–

  • github
  • github/openchronology/timeline-app
  • github/openchronology/timeline-app#562
  • fix/tag-commas
  • pull request
  • state:merged

Events saved through the API could keep tags with commas, such as `type: sovereign, banking and currency crisis` in the Financial crises timeline on timescale.info. `normalizeEntityTags` left an invalid tag list as it was, but separations validated their tags strictly, so a view selecting those events was refused (`Tags must be 1–128 characters without commas or control characters.`). Commas stay the separator between tags in the editor, and in separation cache keys, so a tag cannot contain one. Instead: - **Normalizing (`src/tags.ts`):** `tagText` turns a comma inside a tag into a semicolon (`a, b` → `a; b`). `validateTags` uses it, so events, timelines and separations all get the same spelling. - **Reading old data:** `entityTags` reads a stored tag that has a comma the same way, so events saved before this change match separations without a migration. - **The server's search index:** rows indexed before this change still hold the comma. The separation tag check and the tag counts read them through the same rule in SQL (`STORED_TAG`). - **Docs and OpenAPI** describe the rule. - **Tests:** a new test in `test/tags.test.mjs`. Three tests that used a comma as their invalid-tag example now use a control character. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_011fFY8eruEi1xAkkMBni13B https://github.com/openchronology/timeline-app/pull/562

Related

Open #562 Make a comma inside a tag a semicolon, so separations select every tag in the timeline

#562 Make a comma inside a tag a semicolon, so separations…