circagraph
Sign inSign up

openchronology/timeline-app on GitHub

The OpenChronology repository on GitHub, mirrored by och-import-github: issues and pull requests as durations (ongoing while open), what happened to them as moments, plus releases, milestones, commits and branches. The Branches view shows the most recently active branches each in a track of its own.

Source: https://github.com/openchronology/timeline-app

3,131 moments · 2026-10-05 CE 20:21:49 UTC – 2026-11-16 CE 12:10:45 UTC · by @athan · @athan

#56 Save and Cancel in the moment and duration dialogs

–

  • github
  • github/openchronology/timeline-app
  • github/openchronology/timeline-app#56
  • pull request
  • state:merged

Fixes #44. - Moment and duration dialogs get **Cancel** and **Save** buttons, shown only when the timeline is editable. - Edits still apply live as they are typed. **Save** flushes pending edits and closes (a new moment is created even if nothing was typed, since its time is already set). Validation errors keep the dialog open. - **Cancel** reverts the entity to how it was opened, removes a newly created moment or duration, and removes that session's undo step, so Undo goes to the previous edit. - New durations now share one history entry between creation and the dialog session, so Cancel can find and drop it. Tests: `moment-dialog-browser.mjs` covers Save, Cancel on edited and new moments (including the undo stack) and on new and edited durations; `tags-browser.mjs` checks that the buttons are hidden while read-only. The plugin test asserted the old no-Save design and now expects the button. Unit, browser and offline suites pass in Chromium and Firefox. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01Ti36soiZpKdSxKfvQLEcfY https://github.com/openchronology/timeline-app/pull/56

Related

Open #56 Save and Cancel in the moment and duration dialogs in the timeline

#56 Save and Cancel in the moment and duration dialogs