#536 Fix "Invalid sign-in return location" for Google and GitHub sign-in
–
- github
- github/openchronology/timeline-app
- github/openchronology/timeline-app#536
- pull request
- state:merged
Signing in with Google or GitHub from `/login` failed with **Invalid sign-in return location**. **Why:** the login page returns to `/explore` when it has no page to go back to, or to a timeline at its named address (`/ / `), but the server's social sign-in accepted neither. The two lists had drifted apart since Explore became the dashboard (#379). **Fix:** - **One list:** `signInReturn` in `src/addresses.ts` is now the single list, used by the login page (`safeReturnTo`) and by `OAuth.start`. The server still accepts the desktop app's old `/#desktop/ ` address. - **Tests:** `auth.test.mjs` checks that Explore, a named timeline and a `/timelines/ ` address start a sign-in, and that other sites, `//host` and unknown pages are refused. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_011fFY8eruEi1xAkkMBni13B https://github.com/openchronology/timeline-app/pull/536
Related
Open #536 Fix "Invalid sign-in return location" for Google and GitHub sign-in in the timeline