#506 Desktop sign-in approval relies on the user noticing a warning (device-code phishing)
–
- github
- github/openchronology/timeline-app
- github/openchronology/timeline-app#506
- issue
- state:closed
**Desktop sign-in approval relies on the user noticing a warning (device-code phishing)** - **Severity: Informational (already mitigated as far as the flow allows).** - **Location:** `platform/components/device-approval.jsx:47-80`, `platform/app/connect/desktop/[code]/page.jsx`. - **Description:** an attacker can start a desktop sign-in, send the link to a victim and tell them the code to type. The page warns prominently, shows the request's address and user agent, and flags a different address. Typing the code adds friction but no secret, because the code is in the link. The page is not frameable (it is in `PAGES`). - **Suggested fix:** keep it as it is. Optionally, refuse approval when the address differs unless the user confirms a second time. - **Confidence:** confirmed (design). --- From the security review of 2026-11-06 (commit 6776c44), finding I-5: hardening or information, filed publicly because it describes no way in. The exploitable findings are private security advisories. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_011fFY8eruEi1xAkkMBni13B https://github.com/openchronology/timeline-app/issues/506