circagraph
Sign inSign up

openchronology/timeline-app on GitHub

The OpenChronology repository on GitHub, mirrored by och-import-github: issues and pull requests as durations (ongoing while open), what happened to them as moments, plus releases, milestones, commits and branches. The Branches view shows the most recently active branches each in a track of its own.

Source: https://github.com/openchronology/timeline-app

3,131 moments · 2026-10-05 CE 20:21:49 UTC – 2026-11-16 CE 12:10:45 UTC · by @athan · @athan

#31 Keep benchmark sizes intact in the Benchmarks workflow

–

  • github
  • github/openchronology/timeline-app
  • github/openchronology/timeline-app#31
  • pull request
  • state:merged

Fixes the failure in Benchmarks run #1. **Cause:** the `sizes` input had an unquoted default, `1000,10000,50000`. It reached the job as `BENCH_SIZES=10001000050000` with the commas stripped. Seeding then tried to allocate a 20-billion-entry cluster array and crashed with `RangeError: Invalid array length`. **Fix** - Quote the default so it stays a string. - Accept commas or spaces between sizes in both the Node harness and the criterion bench. - Reject sizes outside 1–200,000 moments (the document limit) with a clear error, and fall back to the defaults when the value is empty. **Verified:** a Benchmarks run on this branch passed in 11.5 minutes (run 37873190903). It produced all 63 measurements at 1k/10k/50k across the three backends and uploaded the `benchmark-report` artifact. Saving one moment at 50k took 5.6 s on PostgreSQL and 0.62 s on SQLite. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01Ti36soiZpKdSxKfvQLEcfY https://github.com/openchronology/timeline-app/pull/31

Related

Open #31 Keep benchmark sizes intact in the Benchmarks workflow in the timeline

#31 Keep benchmark sizes intact in the Benchmarks workflow