#205 Desktop WebDriver tests can hang until the job limit: WebDriver requests have no time limit
–
- github
- github/openchronology/timeline-app
- github/openchronology/timeline-app#205
- issue
- state:closed
On PR #203, CI's "Desktop app / UI interactions within budget" job sat in its **Desktop bulk edits** step from 19:16 to 20:13 UTC with no output, until the job's 60-minute limit cancelled it ([run 39060988629](https://github.com/openchronology/timeline-app/actions/runs/39060988629/job/117478725864)). That step normally takes 38–50 s. The same commit passed it in 38 s on the push run, and a rerun of the job passed. Of the last 28 runs, this was the only hang, so it looks like a rare WebKitWebDriver/tauri-driver stall, not a regression. ## Why it ran for an hour Every wait in `test/desktop-bulk.mjs` has a time limit, through `d.wait(expression, timeout)`. Each check inside such a wait is a WebDriver request, and those have no time limit: `call` in `bench/ui/webdriver.mjs` uses a plain `fetch` with no `signal`. When the driver stops answering one request, the wait's deadline is never checked again, so only the job limit ends the step. The page-state dump in the test's `catch`, also a WebDriver request, would hang the same way. ## Proposed - Give `call` in `bench/ui/webdriver.mjs` a time limit, such as `signal: AbortSignal.timeout(60000)`. The error should name the method and path that stalled, and keep tauri-driver's recent log, which the test already collects. Session creation, which starts the app, may need a longer limit. - Limit the page-state dump in `test/desktop-bulk.mjs`'s `catch` to a short time, so the original error still comes through. - Add a `timeout-minutes` to the **Desktop bulk edits** and **UI interactions within budget** steps in `.github/workflows/ci.yml`, about 5 and 15 minutes, as a backstop. - `bench/ui.mjs` uses the same helper, so the desktop UI benchmark gains the same protection. A stalled request would then fail in about a minute, with the stalled request named, instead of using up the job's hour. https://github.com/openchronology/timeline-app/issues/205
Related
- #203 .och conversions hold less memory, and their file limit is a setting (#202)
- #206 Desktop WebDriver requests have a time limit, so a stalled driver fails the run (#205)
- Desktop WebDriver requests have a time limit, so a stalled driver fails the run (#205)
- Merge pull request #206 from openchronology/feature/webdriver-timeouts