circagraph
Sign inSign up

openchronology/timeline-app on GitHub

The OpenChronology repository on GitHub, mirrored by och-import-github: issues and pull requests as durations (ongoing while open), what happened to them as moments, plus releases, milestones, commits and branches. The Branches view shows the most recently active branches each in a track of its own.

Source: https://github.com/openchronology/timeline-app

3,131 moments · 2026-10-05 CE 20:21:49 UTC – 2026-11-16 CE 12:10:45 UTC · by @athan · @athan

#193 Things to look at, found writing #177's comments

–

  • github
  • github/openchronology/timeline-app
  • github/openchronology/timeline-app#193
  • issue
  • state:closed

While writing the comments for #177 (PR #192), the reading turned up things that look wrong in the code. Five were confirmed and are fixed in their own PR (a Turnstile bypass via proof of work, mixed-case admin email breaking reset links, `candidates()` cutting history pages before making them distinct, moment ingest's backoff cancelled by each new message, and the admin "Keep the labels" button never showing). The rest are listed here for triage. Each is something noticed while reading the code. None has been reproduced yet, so some may turn out to be fine. ## Behaviour - [ ] **server/http.mjs** maps any `TypeError`, `RangeError` or `SyntaxError` to a 400, and doesn't log it. A real bug in a handler would show up as the client's fault, with nothing in the logs. - [ ] **prepareNow** (copies being prepared) uses `SKIP LOCKED`. A copy whose preparation is skipped this way can stay "being prepared" until the server restarts. - [ ] **Desktop (src-tauri):** there is a race in the generation counter between opening a timeline and accepting a change. - [ ] **native-store:** the SQLite instruction budget is shared across a whole `och-convert` run, not given to each statement or file, so a long conversion can run out of it. - [ ] **Auth throttle:** above 10,000 tracked keys it refuses everyone, not just the busiest addresses. - [ ] **Email change** doesn't check that the new address is free before sending the confirmation, so the failure only comes at confirmation, or as a constraint error. - [ ] **Dashboard comparison selection** is capped at 8 whatever the account's limit is, and the tray text says 8. - [ ] **Avatar preview** sets `crossOrigin="anonymous"`, which breaks previews of images served without CORS headers. - [ ] **Profile tag links** go to `/` instead of the tag's search. - [ ] **Re-enabling an account** (admin) doesn't lift its moderation case. - [ ] **Labelled moderation cases** are outside the "current case" unique index, so a timeline can hold a labelled case alongside another current one. - [ ] **oc_events** (schema.sql) doesn't check `FOUND` after its update, so a missing row passes silently. - [ ] **save()'s 403 message** (server/store.mjs) is "Write access is required to update upstream." for every save, not only a sync from upstream. - [ ] **Custom time tokenizer** reads `x +1` as `x` followed by the signed literal `+1`, not as an addition. - [ ] **calendar-picker** with a non-numeric day: the input isn't validated before it's used. ## Performance (indexes and queries) - [ ] No index leading with `user_id` on `oc_sessions` or `oc_members`. Ending an account's sessions (password and two-factor changes, suspension, email change) reads the whole sessions table. - [ ] No index on the revision-reference columns that `STILL_READ` and `removeHistory` search. - [ ] No index for `event_text_stale`. - [ ] Small tables searched by `user_id` or swept by `expires_at` have no index on them. Cheap now, but not as the tables grow. - [ ] **native-store workspace.rs `related()`** joins on an `OR`, which SQLite may not be able to answer from its indexes. ## Dead code and leftovers - [ ] `oc_timelines.patch_chain` and `patch_bytes` are no longer written or read. - [ ] `oc_track_storage`'s plugin branch is never reached. - [ ] `renderPluginShape` sets `stroke-width` twice. - [ ] `RemoteWorkspace.replacing` is never read. - [ ] Unused imports: `randomUUID` in server/auth.mjs, `ComparisonView` in src/comparison-ui.ts. - [ ] `deploy/plugins.example.json` is mentioned only in deploy/README.md; nothing loads it or explains how to use it. - [ ] The OpenAPI document lists one route twice. https://github.com/openchronology/timeline-app/issues/193

Related

Open #193 Things to look at, found writing #177's comments in the timeline

#193 Things to look at, found writing #177's comments